Bug 144920 - Don't compute selection painting info when we don't have selection
Summary: Don't compute selection painting info when we don't have selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-12 11:54 PDT by Dave Hyatt
Modified: 2015-05-13 11:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2015-05-12 11:57 PDT, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-05-12 11:54:56 PDT 
Don't waste time computing selection painting info when we don't even have a selection.
Comment 1 Dave Hyatt 2015-05-12 11:57:01 PDT 
Created attachment 252974 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-05-12 11:59:49 PDT 
Comment on attachment 252974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252974&action=review

> Source/WebCore/ChangeLog:5
> +

And rdar://problem/20919920

> Source/WebCore/ChangeLog:12
> +        at all. computing the selection style takes time in the case where a ::selection pseudo is

computing -> Computing
Comment 3 Dave Hyatt 2015-05-13 11:57:56 PDT 
Fixed in r184293.