WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
144915
stress/int8-repeat-out-of-bounds.js and stress/float32-repeat-out-of-bounds.js fail with eager compilation
https://bugs.webkit.org/show_bug.cgi?id=144915
Summary
stress/int8-repeat-out-of-bounds.js and stress/float32-repeat-out-of-bounds.j...
Basile Clement
Reported
2015-05-12 10:01:40 PDT
...
Attachments
Add attachment
proposed patch, testcase, etc.
Basile Clement
Comment 1
2015-05-12 10:04:10 PDT
After looking at the test, this is probably a minor problem with the test making assumptions on the number of recompilations that is not correct with eager compilation.
Filip Pizlo
Comment 2
2015-05-12 10:38:56 PDT
It's intentional. :-). The tests are asserting that we converge quickly and don't recompile too much. But with eager compilation, we will recompile more because we often don't get enough profiling in the first round. That's fine. I don't think we should try to make these tests pass in eager mode
Basile Clement
Comment 3
2015-05-12 12:27:01 PDT
(In reply to
comment #2
)
> It's intentional. :-). The tests are asserting that we converge quickly and > don't recompile too much. But with eager compilation, we will recompile more > because we often don't get enough profiling in the first round. That's fine. > I don't think we should try to make these tests pass in eager mode
OK, it just seemed weird that we had tests that would only succeed provided some options are within presupposed range, closing this then.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug