Bug 144901 - Array.slice should have a fast path like Array.splice
Summary: Array.slice should have a fast path like Array.splice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-11 22:50 PDT by Ryosuke Niwa
Modified: 2015-05-12 14:05 PDT (History)
5 users (show)

See Also:


Attachments
Adds a fast path (4.32 KB, patch)
2015-05-11 22:53 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-05-11 22:50:50 PDT
Just memcopy stuff.
Comment 1 Ryosuke Niwa 2015-05-11 22:53:23 PDT
Created attachment 252941 [details]
Adds a fast path
Comment 2 Geoffrey Garen 2015-05-12 12:18:41 PDT
Comment on attachment 252941 [details]
Adds a fast path

r=me

We should really implement these functions in JS.
Comment 3 Ryosuke Niwa 2015-05-12 13:15:42 PDT
Comment on attachment 252941 [details]
Adds a fast path

Thanks for the review. Let me see how implementing this in JS will turn out. But for now, we can land this for an incremental improvement.
Comment 4 WebKit Commit Bot 2015-05-12 14:05:37 PDT
Comment on attachment 252941 [details]
Adds a fast path

Clearing flags on attachment: 252941

Committed r184217: <http://trac.webkit.org/changeset/184217>
Comment 5 WebKit Commit Bot 2015-05-12 14:05:42 PDT
All reviewed patches have been landed.  Closing bug.