WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144898
AX: [EFL] Consider deferring to WebCore Accessibility for table exposure
https://bugs.webkit.org/show_bug.cgi?id=144898
Summary
AX: [EFL] Consider deferring to WebCore Accessibility for table exposure
Joanmarie Diggs
Reported
2015-05-11 22:08:15 PDT
I suspect that the reason WebKitEfl exposes all tables (data and layout) as AccessibilityTables is because they inherited that expectation from WebKitGtk. As I indicated in
bug 144896
, there doesn't seem to be much point in continuing to override WebCore Accessibility -- at least not for WebKitGtk. If the only reason you do it in Efl is because we <strike>do</strike> did it in Gtk, it might be nice to get rid of this platform difference. (BTW, I'd propose a patch myself but I'm having trouble at the moment building WebKitEfl. And the tests that spit out all attributes, including bounding boxes, are something one cannot take an educated guess at.)
Attachments
Patch
(10.94 KB, patch)
2015-12-08 08:53 PST
,
Joanmarie Diggs
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-05-11 22:08:40 PDT
<
rdar://problem/20911606
>
Gyuyoung Kim
Comment 2
2015-12-07 13:42:07 PST
(In reply to
comment #0
)
> (BTW, I'd propose a patch myself but I'm having trouble at the moment > building WebKitEfl. And the tests that spit out all attributes, including > bounding boxes, are something one cannot take an educated guess at.)
I take a look the
Bug 144896
. First of all the updated expectations have been marked to *failure* in EFL port.
http://trac.webkit.org/browser/trunk/LayoutTests/platform/efl/TestExpectations#L1824
I'm not sure if EFL port needs to do something further yet. If you have patch for EFL port, please upload it to take a look.
> (BTW, I'd propose a patch myself but I'm having trouble at the moment building WebKitEfl.
Please following below instruction to build EFL port. Build step is similar to GTK port. 1. ./Tools/efl/install-dependencies 2. ./Tools/Scripts/build-webkit --efl --update-efl 3. ./Tools/Scripts/run-webkit-tests --efl test-path (e.g. fast/forms/plaintext-mode-1.html)
Joanmarie Diggs
Comment 3
2015-12-08 08:53:22 PST
Created
attachment 266890
[details]
Patch
WebKit Commit Bot
Comment 4
2015-12-09 02:09:25 PST
Comment on
attachment 266890
[details]
Patch Clearing flags on attachment: 266890 Committed
r193813
: <
http://trac.webkit.org/changeset/193813
>
WebKit Commit Bot
Comment 5
2015-12-09 02:09:28 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug