WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
144887
Show unparented tiles in the UI-side compositing tiled scrolling indicator
https://bugs.webkit.org/show_bug.cgi?id=144887
Summary
Show unparented tiles in the UI-side compositing tiled scrolling indicator
Simon Fraser (smfr)
Reported
2015-05-11 15:46:25 PDT
Show unparented tiles in the UI-side compositing tiled scrolling indicator
Attachments
Patch
(47.07 KB, patch)
2015-05-11 15:58 PDT
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2015-05-11 15:58:36 PDT
Created
attachment 252903
[details]
Patch
Tim Horton
Comment 2
2015-05-11 16:48:21 PDT
Comment on
attachment 252903
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=252903&action=review
> Source/WebCore/ChangeLog:20 > + to tell GraphicsLayerCA when the unparented tiles changed.
extra space
> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.h:77 > + > + > +
so many newlines
> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.mm:70 > + RetainPtr<CGColorSpaceRef> colorSpace = adoptCF(CGColorSpaceCreateDeviceRGB());
We have a shared one of these in GraphicsContextCG if you want to use it (lots of things do).
> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.mm:78 > + RetainPtr<CALayer *> layer = adoptNS([[CALayer alloc] init]);
No star needed.
Ahmad Saleem
Comment 3
2022-10-26 03:47:19 PDT
Checking with BugID on Webkit GitHub, it seems this r+ patch didn't landed. Do we need this anymore? Thanks!
Simon Fraser (smfr)
Comment 4
2022-10-26 09:54:17 PDT
Yeah, still useful.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug