Show unparented tiles in the UI-side compositing tiled scrolling indicator

[Simon Fraser (smfr)]

Show unparented tiles in the UI-side compositing tiled scrolling indicator

[Simon Fraser (smfr)]

Created attachment 252903 [details]
Patch

[Tim Horton]

Comment on attachment 252903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252903&action=review

> Source/WebCore/ChangeLog:20
> +        to  tell GraphicsLayerCA when the unparented tiles changed.

extra space

> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.h:77
> +
> +
> +

so many newlines

> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.mm:70
> +    RetainPtr<CGColorSpaceRef> colorSpace = adoptCF(CGColorSpaceCreateDeviceRGB());

We have a shared one of these in GraphicsContextCG if you want to use it (lots of things do).

> Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.mm:78
> +        RetainPtr<CALayer *> layer = adoptNS([[CALayer alloc] init]);

No star needed.

[Ahmad Saleem]

Checking with BugID on Webkit GitHub, it seems this r+ patch didn't landed.

Do we need this anymore? Thanks!

[Simon Fraser (smfr)]

Yeah, still useful.