Bug 144884 - Simplify shim path computation
Summary: Simplify shim path computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-11 15:23 PDT by Anders Carlsson
Modified: 2015-05-11 18:11 PDT (History)
0 users

See Also:

Attachments
Patch (6.47 KB, patch)
2015-05-11 15:25 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-05-11 15:23:44 PDT 
Simplify shim path computation
Comment 1 Anders Carlsson 2015-05-11 15:25:51 PDT 
Created attachment 252896 [details]
Patch
Comment 2 Anders Carlsson 2015-05-11 15:33:03 PDT 
Committed r184125: <http://trac.webkit.org/changeset/184125>
Comment 3 Darin Adler 2015-05-11 18:11:19 PDT 
Comment on attachment 252896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252896&action=review

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:97
> +static RetainPtr<NSString> computeProcessShimPath(const ProcessLauncher::LaunchOptions& launchOptions, NSBundle *webKitBundle)

Why to just NSString * for the return value? Seems like all the code paths return something autoreleased.