Bug 144882 - Web Inspector: REGRESSION (r181625): Timeline recording started from console.profile is always empty
Summary: Web Inspector: REGRESSION (r181625): Timeline recording started from console....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on: 144946
Blocks:
  Show dependency tree / graph
 
Reported: 2015-05-11 14:35 PDT by Matt Baker
Modified: 2015-05-15 20:48 PDT (History)
9 users (show)

See Also:

Attachments
[Patch] Proposed Fix (1.69 KB, patch)
2015-05-12 14:29 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (1.83 KB, patch)
2015-05-13 14:47 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-05-11 14:35:52 PDT 
* SUMMARY
Timeline recording started from console.profile is always empty.

The recording starts and stops (this is noticeable when profiling long-running code), but not timeline records are added.

* STEPS TO REPRODUCE
1. Open the Inspector, go to Timelines
2. Start profiling from the console: console.profile("My profile")
3. Execute some JavaScript
4. Stop profiling: console.profileEnd("My profile")
  => console.profile causes a new recording to start, but no records are added
Comment 1 Radar WebKit Bug Importer 2015-05-11 14:36:20 PDT 
<rdar://problem/20905235>
Comment 2 Matt Baker 2015-05-12 14:29:34 PDT 
Created attachment 252985 [details]
[Patch] Proposed Fix
Comment 3 Brian Burg 2015-05-12 14:32:15 PDT 
Comment on attachment 252985 [details]
[Patch] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2015-05-12 16:14:28 PDT 
Comment on attachment 252985 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 252985

Committed r184224: <http://trac.webkit.org/changeset/184224>
Comment 5 WebKit Commit Bot 2015-05-12 16:14:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2015-05-12 18:24:11 PDT 
This made inspector/page/main-frame-resource.hmtl assert every time:

https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r184224%20(4610)/inspector/page/main-frame-resource-crash-log.txt
Comment 7 Alexey Proskuryakov 2015-05-12 22:14:10 PDT 
Rolling out.
Comment 8 WebKit Commit Bot 2015-05-12 22:15:47 PDT 
Re-opened since this is blocked by bug 144946
Comment 9 Matt Baker 2015-05-13 14:47:26 PDT 
Created attachment 253061 [details]
[Patch] Proposed Fix
Comment 10 Joseph Pecoraro 2015-05-15 19:51:16 PDT 
Comment on attachment 253061 [details]
[Patch] Proposed Fix

r=me
Comment 11 WebKit Commit Bot 2015-05-15 20:47:55 PDT 
Comment on attachment 253061 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 253061

Committed r184428: <http://trac.webkit.org/changeset/184428>
Comment 12 WebKit Commit Bot 2015-05-15 20:48:01 PDT 
All reviewed patches have been landed.  Closing bug.