Bug 144836 – Use preview view controller from WebKitSystemInterface.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yongjun Zhang]

See title, we should use view controller prepared in WebKitSystemInterface.

[Yongjun Zhang]

<rdar://problem/20735668>

[Yongjun Zhang]

Created attachment 252791 [details]
Patch.

Comment on attachment 252791 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=252791&action=review

This looks OK to me. I am surprised that the new property is being introduced as API right away rather than SPI. I’d like someone else from Apple to review this aspect.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:235
> +@property (nonatomic) BOOL allowsLinkPreview;

This needs WK_AVAILABLE(NA, WK_IOS_TBA).

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:45
> +#if USE(APPLE_INTERNAL_SDK)
> +#import <WebKitAdditions/LinkPreviewDefines.h>
> +#endif

These lines should move  to a separate paragraph, after the non-conditional imports.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3116
> +    _previewGestureRecognizer.clear();

We seem to prefer “= nil” to clear().

[Yongjun Zhang]

Created attachment 252821 [details]
New patch.

Make allowsLinkPreview a private property.

Comment on attachment 252821 [details]
New patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=252821&action=review

> Source/WebKit2/ChangeLog:23
> +        (-[WKContentView previewViewControllerForPosition:inSourceView:]): : For client that doesn't provide

: :

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:131
> +@property (nonatomic, getter=_allowsLinkPreview, setter=_setAllowsLinkPreview:) BOOL _allowsLinkPreview;

No need for a custom getter here since it’s the same as the property name. Needs WK_AVAILABLE(NA, WK_IOS_TBA).

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:211
> +
> +- (void)_registerPreviewInWindow:(UIWindow *)window;
> +- (void)_unregisterPreviewInWindow:(UIWindow *)window;

Weird to have a newline before but not after.

[Yongjun Zhang]

Created attachment 252831 [details]
Address review comment for landing.

[WebKit Commit Bot]

Comment on attachment 252831 [details]
Address review comment for landing.

Clearing flags on attachment: 252831

Committed r184061: <http://trac.webkit.org/changeset/184061>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.