Bug 144825 – Introduce ParentNode.idl / NonDocumentTypeChildNode.idl

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Introduce ParentNode.idl / NonDocumentTypeChildNode.idl as per DOM spec and to avoid IDL code duplication:
https://dom.spec.whatwg.org/#interface-parentnode
https://dom.spec.whatwg.org/#interface-nondocumenttypechildnode

[Chris Dumez]

Created attachment 252769 [details]
Patch

[Build Bot]

Comment on attachment 252769 [details]
Patch

Attachment 252769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6043336133574656

New failing tests:
js/dom/dom-static-property-for-in-iteration.html

[Build Bot]

Created attachment 252771 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 252769 [details]
Patch

Attachment 252769 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5107545974767616

New failing tests:
js/dom/dom-static-property-for-in-iteration.html

[Build Bot]

Created attachment 252773 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Chris Dumez]

Created attachment 252777 [details]
Patch

[Chris Dumez]

Created attachment 252782 [details]
Patch

[Sam Weinig]

Comment on attachment 252782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252782&action=review

Nice. I didn't realize we supported the implements syntax.

> Source/WebCore/dom/NonDocumentTypeChildNode.idl:18
> +/*
> + * Copyright (C) 2015 Apple Inc. All rights reserved.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + */

This should probably be the two-clause BSD license.

> Source/WebCore/dom/ParentNode.idl:18
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + */

This should probably be the two-clause BSD license.

[Chris Dumez]

Created attachment 252796 [details]
Patch

[Chris Dumez]

Comment on attachment 252796 [details]
Patch

Clearing flags on attachment: 252796

Committed r184042: <http://trac.webkit.org/changeset/184042>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

(In reply to comment #8)
> Comment on attachment 252782 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252782&action=review
> 
> Nice. I didn't realize we supported the implements syntax.

Yes, for almost 2 years: http://trac.webkit.org/changeset/151740. It was needed to get rid of IDL multiple inheritance in SVG.