Bug 144815 - Creating a large MarkedBlock sometimes results in more than one cell in the block
Summary: Creating a large MarkedBlock sometimes results in more than one cell in the b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-08 14:39 PDT by Michael Saboff
Modified: 2015-05-08 15:55 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2015-05-08 15:22 PDT, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-05-08 14:39:44 PDT 
The large block allocator is designed so that only one block should be in a MarkedBlock.  In some cases the current code can allocate a large MarkedBlock that has 2 cells.  Things fall over dead when this happens.

rdar://problem/20764509
Comment 1 Michael Saboff 2015-05-08 15:22:55 PDT 
Created attachment 252752 [details]
Patch
Comment 2 Mark Lam 2015-05-08 15:24:51 PDT 
Comment on attachment 252752 [details]
Patch

r=me
Comment 3 Mark Lam 2015-05-08 15:25:46 PDT 
Comment on attachment 252752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252752&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        m_endAtom for large blocks to use the location of the first block + 1.  This

s/first block/first cell/
Comment 4 Michael Saboff 2015-05-08 15:27:20 PDT 
(In reply to comment #3)
> Comment on attachment 252752 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252752&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        m_endAtom for large blocks to use the location of the first block + 1.  This
> 
> s/first block/first cell/

Fixed locally.
Comment 5 Michael Saboff 2015-05-08 15:55:44 PDT 
Committed r184019: <http://trac.webkit.org/changeset/184019>