Bug 144813 – streams/reference-implementation/readable-stream-reader.html and streams/reference-implementation/bad-underlying-sources.html are flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

These two files have tests that were previously timeouting and are now passing.
We should remove the 50 ms timeout set for these tests to remove the flakiness that happen for slow bots.

[youenn fablet]

Created attachment 252748 [details]
Patch

[youenn fablet]

Comment on attachment 252748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252748&action=review

> LayoutTests/ChangeLog:9
> +

As we add new features, some failing tests may be timeouting.
We can mark all these newly timeouting tests as {timeout: 50} to continue monitor them (far easier than commenting/uncommenting them).
When being fixed with additional patches, we then remove the {timeout: 50}

Also some tests have been commented out in the past and could have the same treatment.

I wonder whether this kind of change (this patch or proposed uncommenting of tests) needs a review or not.

[Alexey Proskuryakov]

Comment on attachment 252748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252748&action=review

>> LayoutTests/ChangeLog:9
>> +
> 
> As we add new features, some failing tests may be timeouting.
> We can mark all these newly timeouting tests as {timeout: 50} to continue monitor them (far easier than commenting/uncommenting them).
> When being fixed with additional patches, we then remove the {timeout: 50}
> 
> Also some tests have been commented out in the past and could have the same treatment.
> 
> I wonder whether this kind of change (this patch or proposed uncommenting of tests) needs a review or not.

TestExpectations changes don't need review in general, test changes generally do.

[WebKit Commit Bot]

Comment on attachment 252748 [details]
Patch

Clearing flags on attachment: 252748

Committed r184038: <http://trac.webkit.org/changeset/184038>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.