Bug 144797 - Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTransformOperation
Summary: Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTrans...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 144876
Blocks:
  Show dependency treegraph
 
Reported: 2015-05-08 02:50 PDT by Zan Dobersek
Modified: 2015-05-12 23:48 PDT (History)
0 users

See Also:


Attachments
Patch (4.75 KB, patch)
2015-05-08 02:57 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (5.24 KB, patch)
2015-05-12 03:14 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2015-05-08 02:50:52 PDT
Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTransformOperation
Comment 1 Zan Dobersek 2015-05-08 02:57:44 PDT
Created attachment 252715 [details]
Patch
Comment 2 Darin Adler 2015-05-10 14:56:54 PDT
Comment on attachment 252715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252715&action=review

> Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.cpp:38
> +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress)

New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>.

> Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.cpp:37
> +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress)

New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>.
Comment 3 Zan Dobersek 2015-05-11 11:20:04 PDT
Uploaded a patch for PassRefPtr removal in the TransformOperation hierarchy in bug #144876.
Comment 4 Zan Dobersek 2015-05-12 03:14:18 PDT
Created attachment 252952 [details]
Patch for landing
Comment 5 Zan Dobersek 2015-05-12 23:48:46 PDT
Comment on attachment 252952 [details]
Patch for landing

Clearing flags on attachment: 252952

Committed r184274: <http://trac.webkit.org/changeset/184274>
Comment 6 Zan Dobersek 2015-05-12 23:48:53 PDT
All reviewed patches have been landed.  Closing bug.