Fix the wrong condition check at the first line of SVGLengthContext::valueForLength().
We can replace "length.isPercent() && !length.isCalculated()" with "length.isPercentNotCalculated()" for simplicity and clarity.
Created attachment 252703 [details] Patch
Comment on attachment 252703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252703&action=review > Source/WebCore/svg/SVGLengthContext.cpp:92 > + if (length.isPercentNotCalculated()) It will be beneficial if we can rename: Length::isPercentNotCalculated() => Length::isPercent() Length::isPercent() => Length::isPercentOrCalculated() // Or something similar Then we can remove the following FIXME from Length.h bool isPercentNotCalculated() const; // FIXME: Rename to isPercent. And the above condition will be simpler and clearer.
Created attachment 252744 [details] Patch
Addressed Said Abou-Hallawa's comments.
Created attachment 252746 [details] Patch
Comment on attachment 252746 [details] Patch It’s dangerous to do this all in one pass. If we missed any call site, the behavior will become wrong and the compiler won’t catch it for us. The safe way to do this is to do the rename of isPercent to isPercentOrCalculated in a first patch, then do the rest in a second patch after we know all platforms compile.
Comment on attachment 252746 [details] Patch Clearing flags on attachment: 252746 Committed r184055: <http://trac.webkit.org/changeset/184055>
All reviewed patches have been landed. Closing bug.
@Darin Adler: Oops, but the patch has already been committed. Next time, I will be sure to follow your advice. Thank you for your thoughtful review.