Bug 144785 - [GTK] Fails to link libwebkit2gtkinjectedbundle.so on OSX
Summary: [GTK] Fails to link libwebkit2gtkinjectedbundle.so on OSX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.10
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 126492 144561
  Show dependency tree / graph
 
Reported: 2015-05-07 23:26 PDT by Philip Chimento
Modified: 2015-11-06 01:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2015-05-07 23:40 PDT, Philip Chimento 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Chimento 2015-05-07 23:26:47 PDT 
On GTK / OSX, the build fails with this error:

Linking CXX shared module ../../lib/libwebkit2gtkinjectedbundle.so
Undefined symbols for architecture x86_64:
  "WebKit::WebGtkExtensionManager::initialize(OpaqueWKBundle const*, void const*)", referenced from:
      _WKBundleInitialize in WebGtkInjectedBundleMain.cpp.o
  "WebKit::WebGtkExtensionManager::shared()", referenced from:
      _WKBundleInitialize in WebGtkInjectedBundleMain.cpp.o
ld: symbol(s) not found for architecture x86_64
make[2]: *** [lib/libwebkit2gtkinjectedbundle.so] Error 1
make[1]: *** [Source/WebKit2/CMakeFiles/webkit2gtkinjectedbundle.dir/all] Error 2
Comment 1 Philip Chimento 2015-05-07 23:40:40 PDT 
Created attachment 252690 [details]
Patch
Comment 2 Michael Catanzaro 2015-06-28 15:34:40 PDT 
I wonder why this is necessary....
Comment 3 Philip Chimento 2015-07-01 22:49:06 PDT 
(In reply to comment #2)
> I wonder why this is necessary....

I'm not sure either. I suspect it's due to some difference in how XCode's linker handles other DSOs linked by the objects it's linking. Perhaps GNU's linker pulls them in, while XCode's linker requires them to be explicitly added to the linker command line.
Comment 4 WebKit Commit Bot 2015-11-06 01:49:40 PST 
Comment on attachment 252690 [details]
Patch

Clearing flags on attachment: 252690

Committed r192096: <http://trac.webkit.org/changeset/192096>
Comment 5 WebKit Commit Bot 2015-11-06 01:49:43 PST 
All reviewed patches have been landed.  Closing bug.