Bug 144779 – Clean up some possible RefPtr to PassRefPtr churn

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

* SUMMARY
Clean up some possible RefPtr to PassRefPtr churn.

There are a few cases where the last use of a RefPtr can be releasing and isn't. This could likely converted to rvalue references, but for now just using release() should save a ref churn.

[Joseph Pecoraro]

Created attachment 252670 [details]
[PATCH] Proposed Fix

Lets see what the bots think of this.

[Joseph Pecoraro]

Comment on attachment 252670 [details]
[PATCH] Proposed Fix

LayoutTests/js tests passed for me locally.

[Darin Adler]

Comment on attachment 252670 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=252670&action=review

Breaks the GTK build.

> Source/JavaScriptCore/ChangeLog:20
> +        Release the last use of a RefPtr as it is passed on.

Need to move these call sites to RefPtr or Ref instead of PassRefPtr: <http://www.webkit.org/coding/RefPtr.html>. Then the issue will still exist, but in far fewer cases because the compiler will do the move optimization since it can see the lifetimes.

> Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:70
> +    return adoptRef(new GenericTypedArrayView(buffer.release(), byteOffset, length));

platform/graphics/ISOVTTCue.cpp.o:ISOVTTCue.cpp:function WebCore::ISOBox::peekString(JSC::ArrayBuffer*, unsigned int, unsigned int): error: undefined reference to 'JSC::GenericTypedArrayView<JSC::Uint8Adaptor>::create(WTF::PassRefPtr<JSC::ArrayBuffer>, unsigned int, unsigned int)'

[Joseph Pecoraro]

Comment on attachment 252670 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=252670&action=review

>> Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h:70
>> +    return adoptRef(new GenericTypedArrayView(buffer.release(), byteOffset, length));
> 
> platform/graphics/ISOVTTCue.cpp.o:ISOVTTCue.cpp:function WebCore::ISOBox::peekString(JSC::ArrayBuffer*, unsigned int, unsigned int): error: undefined reference to 'JSC::GenericTypedArrayView<JSC::Uint8Adaptor>::create(WTF::PassRefPtr<JSC::ArrayBuffer>, unsigned int, unsigned int)'

Hmm, I don't understand the error. I'm not changing the signature of anything and the error messages don't mention an error inside the inline code, just that the top level method is not available.

Maybe "undefined reference to" might mean it doesn't have an include it needs to TypedArrayInlines? How would this have worked before?

[Joseph Pecoraro]

Created attachment 253048 [details]
[PATCH] For Bots

[Joseph Pecoraro]

Created attachment 253055 [details]
[PATCH] For Bots

[Joseph Pecoraro]

Comment on attachment 253055 [details]
[PATCH] For Bots

Yay. Seems it might have just been missing includes.

[WebKit Commit Bot]

Comment on attachment 253055 [details]
[PATCH] For Bots

Clearing flags on attachment: 253055

Committed r184325: <http://trac.webkit.org/changeset/184325>