Bug 144778 – REGRESSION (r183300): Fixed elements flash when scrolling

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

REGRESSION (r183300): Fixed elements flash when scrolling

[Simon Fraser (smfr)]

Created attachment 252671 [details]
Patch

[Simon Fraser (smfr)]

rdar://problem/20769741

[Dean Jackson]

Comment on attachment 252671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252671&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:153
> -        bool ancestorHasTransformAnimation;
> -        int treeDepth;
> -        CommitState()
> -            : ancestorHasTransformAnimation(false)
> -            , treeDepth(0)
> -        { }
> +        int treeDepth { 0 };
> +        bool ancestorHasTransformAnimation { false };
> +        bool ancestorsAllowBackingStoreDetachment { true };

Nice!

[Simon Fraser (smfr)]

https://trac.webkit.org/r183970

[Chris Dumez]

Follow-up build fix in <http://trac.webkit.org/changeset/183980> for:
"""
ERROR: WebCore has a weak external symbol in it (/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol __ZNK7WebCore15GraphicsLayerCA28allowsBackingStoreDetachmentEv
Command /bin/sh failed with exit code 1
"""

[Simon Fraser (smfr)]

Thanks for the build fix, Chris.