RESOLVED FIXED144777
[iOS] MediaControls: disappear while scrubbing 
https://bugs.webkit.org/show_bug.cgi?id=144777
Summary [iOS] MediaControls: disappear while scrubbing
Dean Jackson
Reported 2015-05-07 18:03:54 PDT
[iOS] MediaControls: disappear while scrubbing
Attachments
Patch (2.31 KB, patch)
2015-05-07 18:05 PDT, Dean Jackson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-05-07 18:04:08 PDT
<rdar://problem/20065572>
Dean Jackson
Comment 2 2015-05-07 18:05:29 PDT
Created attachment 252665 [details] Patch
Dean Jackson
Comment 3 2015-05-07 18:56:45 PDT
Committed r183971: <http://trac.webkit.org/changeset/183971>
Jer Noble
Comment 4 2015-05-07 19:27:41 PDT
There were some changes in the commit which were not in the patch, namely changes to mediaControlsApple.js: adding a reference to _potentiallyScrubbing which does not exist in mediaControlsApple.js. We should fix this.
Jer Noble
Comment 5 2015-05-07 19:29:45 PDT
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (revision 183953) +++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (revision 183971) @@ -1363,5 +1363,5 @@ hideControls: function() { - if (this.controlsAlwaysVisible()) + if (this.controlsAlwaysVisible() || this._potentiallyScrubbing) We should revert this change, and modify controlsAlwaysVisible() in mediaControlsIOS.js to return true if this._potentiallyScrubbing is true.
Darin Adler
Comment 6 2015-05-10 15:16:36 PDT
Comment on attachment 252665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252665&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:525 > + this.resetHideControlsTimer(); I think this shows that this function might need a different name. The verb "reset" is perhaps too ambiguous.
Note You need to log in before you can comment on or make changes to this bug.