Bug 144775 - Avoid always running some debug code in type profiling
Summary: Avoid always running some debug code in type profiling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-07 17:12 PDT by Joseph Pecoraro
Modified: 2015-05-13 11:53 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.70 KB, patch)
2015-05-07 17:14 PDT, Joseph Pecoraro 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-07 17:12:52 PDT 
* SUMMARY
Avoid always running some debug code in type profiling.

There is a currentTimeMS call only used by debugging code. Avoid it in the common case.
Comment 1 Joseph Pecoraro 2015-05-07 17:14:03 PDT 
Created attachment 252657 [details]
[PATCH] Proposed Fix

Patch won't apply, because it sits on top of another patch.
Comment 2 Saam Barati 2015-05-07 18:21:13 PDT 
Comment on attachment 252657 [details]
[PATCH] Proposed Fix

Looks good to me.
Comment 3 Daniel Bates 2015-05-07 23:59:03 PDT 
Comment on attachment 252657 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=252657&action=review

> Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:57
> +    double before = 0;

Maybe a better name for this variable would be beginTime. Similarly, maybe a better name for the local variable after would be endTime.
Comment 4 Joseph Pecoraro 2015-05-13 11:53:45 PDT 
http://trac.webkit.org/changeset/184292