WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144775
Avoid always running some debug code in type profiling
https://bugs.webkit.org/show_bug.cgi?id=144775
Summary
Avoid always running some debug code in type profiling
Joseph Pecoraro
Reported
2015-05-07 17:12:52 PDT
* SUMMARY Avoid always running some debug code in type profiling. There is a currentTimeMS call only used by debugging code. Avoid it in the common case.
Attachments
[PATCH] Proposed Fix
(1.70 KB, patch)
2015-05-07 17:14 PDT
,
Joseph Pecoraro
dbates
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2015-05-07 17:14:03 PDT
Created
attachment 252657
[details]
[PATCH] Proposed Fix Patch won't apply, because it sits on top of another patch.
Saam Barati
Comment 2
2015-05-07 18:21:13 PDT
Comment on
attachment 252657
[details]
[PATCH] Proposed Fix Looks good to me.
Daniel Bates
Comment 3
2015-05-07 23:59:03 PDT
Comment on
attachment 252657
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=252657&action=review
> Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:57 > + double before = 0;
Maybe a better name for this variable would be beginTime. Similarly, maybe a better name for the local variable after would be endTime.
Joseph Pecoraro
Comment 4
2015-05-13 11:53:45 PDT
http://trac.webkit.org/changeset/184292
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug