Bug 144760 - Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites
Summary: Add a mechanism to opt-out of the automatic scaling applied to not-really-res...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2015-05-07 14:26 PDT by Tim Horton
Modified: 2015-05-20 13:44 PDT (History)
8 users (show)

See Also:


Attachments
Patch (11.86 KB, patch)
2015-05-07 14:26 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (10.87 KB, patch)
2015-05-07 16:29 PDT, Tim Horton
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-05-07 14:26:19 PDT
Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites
Comment 1 Tim Horton 2015-05-07 14:26:44 PDT
Created attachment 252628 [details]
Patch
Comment 2 Tim Horton 2015-05-07 15:15:33 PDT
Comment on attachment 252628 [details]
Patch

Going in a different direction with this.
Comment 3 Tim Horton 2015-05-07 16:29:05 PDT
Created attachment 252645 [details]
Patch
Comment 4 Darin Adler 2015-05-10 15:20:57 PDT
Comment on attachment 252645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252645&action=review

> Source/WebCore/dom/ViewportArguments.cpp:398
>          // FIXME: Ignore silently for now. This should eventually fallback to the warning.

the verb fall back is two words

> Source/WebCore/dom/ViewportArguments.h:91
> +        , shrinkToFit(ValueAuto)

Should initialize below instead of here in the constructor (now that we can).

> Source/WebCore/dom/ViewportArguments.h:109
> +    float shrinkToFit;

I don’t get why this is a float.

> Source/WebCore/page/ViewportConfiguration.cpp:306
> +    if (booleanViewportArgumentIsSet(m_viewportArguments.userZoom))
>          m_configuration.allowsUserScaling = m_viewportArguments.userZoom != 0.;

Strange to use a function for one thing and inline code for the other. Also the use of != 0. here is strangely different from what booleanViewportArgumentIsSet does.
Comment 5 Tim Horton 2015-05-20 13:43:30 PDT
http://trac.webkit.org/changeset/184654
Comment 6 Radar WebKit Bug Importer 2015-05-20 13:44:47 PDT
<rdar://problem/21044514>