Bug 144760 – Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites

[Tim Horton]

Created attachment 252628 [details]
Patch

[Tim Horton]

Comment on attachment 252628 [details]
Patch

Going in a different direction with this.

[Tim Horton]

Created attachment 252645 [details]
Patch

[Darin Adler]

Comment on attachment 252645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252645&action=review

> Source/WebCore/dom/ViewportArguments.cpp:398
>          // FIXME: Ignore silently for now. This should eventually fallback to the warning.

the verb fall back is two words

> Source/WebCore/dom/ViewportArguments.h:91
> +        , shrinkToFit(ValueAuto)

Should initialize below instead of here in the constructor (now that we can).

> Source/WebCore/dom/ViewportArguments.h:109
> +    float shrinkToFit;

I don’t get why this is a float.

> Source/WebCore/page/ViewportConfiguration.cpp:306
> +    if (booleanViewportArgumentIsSet(m_viewportArguments.userZoom))
>          m_configuration.allowsUserScaling = m_viewportArguments.userZoom != 0.;

Strange to use a function for one thing and inline code for the other. Also the use of != 0. here is strangely different from what booleanViewportArgumentIsSet does.

[Tim Horton]

http://trac.webkit.org/changeset/184654

[Radar WebKit Bug Importer]

<rdar://problem/21044514>