Bug 144748 – [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

This is needed by local applications loaded as a file URI that do XMLHttpRequests.

[Carlos Garcia Campos]

Created attachment 252594 [details]
Patch

[Sergio Villar Senin]

Comment on attachment 252594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252594&action=review

That's a r=me. Another WebKitGtk reviewer must approve the new API though

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> +    if (currentValue == allowed)

currentValue is not really needed. I think using the function call directly is explicit enough.

[Carlos Garcia Campos]

(In reply to comment #2)
> Comment on attachment 252594 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252594&action=review
> 
> That's a r=me. Another WebKitGtk reviewer must approve the new API though

Thanks!, you can safely r+, cq- I won't land it until I get the second approval.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> > +    if (currentValue == allowed)
> 
> currentValue is not really needed. I think using the function call directly
> is explicit enough.

Yes, we have that pattern in the whole file, I don't remember if there was a reason, or we just copy-pasted every time :-)

[Gustavo Noronha (kov)]

Comment on attachment 252594 [details]
Patch

Yep, makes sense to me =)

[Carlos Garcia Campos]

Committed r183992: <http://trac.webkit.org/changeset/183992>