Bug 144748 - [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
Summary: [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-05-07 09:34 PDT by Carlos Garcia Campos
Modified: 2015-05-08 04:55 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.63 KB, patch)
2015-05-07 09:38 PDT, Carlos Garcia Campos 		svillar: review+
svillar: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-05-07 09:34:58 PDT 
This is needed by local applications loaded as a file URI that do XMLHttpRequests.
Comment 1 Carlos Garcia Campos 2015-05-07 09:38:34 PDT 
Created attachment 252594 [details]
Patch
Comment 2 Sergio Villar Senin 2015-05-07 23:45:01 PDT 
Comment on attachment 252594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252594&action=review

That's a r=me. Another WebKitGtk reviewer must approve the new API though

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> +    if (currentValue == allowed)

currentValue is not really needed. I think using the function call directly is explicit enough.
Comment 3 Carlos Garcia Campos 2015-05-07 23:57:45 PDT 
(In reply to comment #2)
> Comment on attachment 252594 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252594&action=review
> 
> That's a r=me. Another WebKitGtk reviewer must approve the new API though

Thanks!, you can safely r+, cq- I won't land it until I get the second approval.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060
> > +    if (currentValue == allowed)
> 
> currentValue is not really needed. I think using the function call directly
> is explicit enough.

Yes, we have that pattern in the whole file, I don't remember if there was a reason, or we just copy-pasted every time :-)
Comment 4 Gustavo Noronha (kov) 2015-05-08 04:23:20 PDT 
Comment on attachment 252594 [details]
Patch

Yep, makes sense to me =)
Comment 5 Carlos Garcia Campos 2015-05-08 04:55:26 PDT 
Committed r183992: <http://trac.webkit.org/changeset/183992>