To be able to see any warnings in our code when compiling with Clang, which gives tons of warnings for problems in other projects' header files, we need to mark them as SYSTEM headers. The first parameter to include_directories() should be SYSTEM, then all warnings from headers in those directories will be suppressed, using -isystem instead of -I.
The forthcoming patch is not ready for review, due to concerns about a CMake version bump: https://lists.webkit.org/pipermail/webkit-dev/2015-May/027436.html I think we might be able to do a WEBKIT_TARGET_INCLUDE_DIRECTORIES compatibility macro. The implementation would not be pretty, though. But I see almost everywhere we need this is in PlatformGTK.cmake, with just one exception. I'm thinking the path of least resistance is to require CMake 2.8.12 only in PlatformGTK.cmake, and guard the one use that affects Mac with a version check.
(In reply to comment #1) > But I > see almost everywhere we need this is in PlatformGTK.cmake, with just one > exception. Actually, we don't even need to do that. I was inconsistently treating our bundled ANGLE as a system library to suppress warnings from, but it's not a system library, we should show warnings from its headers, it's our responsibility because we bundle it. And that's the only case that matters for Macs.
This is ready for review. I'm having trouble building it fully do to a different bug; let's see what EWS thinks.
Created attachment 253040 [details] Patch
Attachment 253040 [details] did not pass style-queue: ERROR: Source/WebKit2/PlatformGTK.cmake:491: Alphabetical sorting problem. "PluginProcess/PluginControllerProxy.cpp" should be before "PluginProcess/EntryPoint/unix/PluginProcessMain.cpp". [list/order] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 253047 [details] Patch
Attachment 253047 [details] did not pass style-queue: ERROR: Source/WebKit2/PlatformGTK.cmake:491: Alphabetical sorting problem. "PluginProcess/PluginControllerProxy.cpp" should be before "PluginProcess/EntryPoint/unix/PluginProcessMain.cpp". [list/order] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 253140 [details] Patch
Attachment 253140 [details] did not pass style-queue: ERROR: Source/WebKit2/PlatformGTK.cmake:491: Alphabetical sorting problem. "PluginProcess/PluginControllerProxy.cpp" should be before "PluginProcess/EntryPoint/unix/PluginProcessMain.cpp". [list/order] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 253140 [details] Patch I think EFL port also needs to use this patch.
Comment on attachment 253140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253140&action=review > CMakeLists.txt:1 > -cmake_minimum_required(VERSION 2.8.8) > +cmake_minimum_required(VERSION 2.8.12) :)
Comment on attachment 253140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253140&action=review >> CMakeLists.txt:1 >> +cmake_minimum_required(VERSION 2.8.12) > > :) I believe you let Mac cmake ports use newer ver. in near future ;)
(In reply to comment #11) > > CMakeLists.txt:1 > > -cmake_minimum_required(VERSION 2.8.8) > > +cmake_minimum_required(VERSION 2.8.12) > > :) Ah, I should have called that out: I decided to do this unconditionally since you decided it wouldn't hurt your efforts. Seems easiest to have one minimum for the entire build system.
Comment on attachment 253140 [details] Patch Clearing flags on attachment: 253140 Committed r184536: <http://trac.webkit.org/changeset/184536>
All reviewed patches have been landed. Closing bug.