[WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode.

[Jer Noble]

[WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode.

[Jer Noble]

Created attachment 252525 [details]
Patch

[Darin Adler]

Comment on attachment 252525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252525&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303
> +        [contentView.layer removeAllAnimations];
> +        [[_clipView layer] removeAllAnimations];
> +        [[_clipView layer].mask removeAllAnimations];

Strange to mix x.layer and [x layer] here.

[Jer Noble]

Comment on attachment 252525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252525&action=review

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303
>> +        [[_clipView layer].mask removeAllAnimations];
> 
> Strange to mix x.layer and [x layer] here.

Id love it if we could use dot-notation with RetainPtr<>. We could also do foo,get().layer.

[Jer Noble]

<rdar://problem/20702435>

[WebKit Commit Bot]

Comment on attachment 252525 [details]
Patch

Clearing flags on attachment: 252525

Committed r183911: <http://trac.webkit.org/changeset/183911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.