WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144716
[WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=144716
Summary
[WK2][Fullscreen] Elements whose children extend beyond their bounds are clip...
Jer Noble
Reported
2015-05-06 15:12:34 PDT
[WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode.
Attachments
Patch
(2.27 KB, patch)
2015-05-06 15:19 PDT
,
Jer Noble
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2015-05-06 15:19:05 PDT
Created
attachment 252525
[details]
Patch
Darin Adler
Comment 2
2015-05-06 16:52:48 PDT
Comment on
attachment 252525
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=252525&action=review
> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303 > + [contentView.layer removeAllAnimations]; > + [[_clipView layer] removeAllAnimations]; > + [[_clipView layer].mask removeAllAnimations];
Strange to mix x.layer and [x layer] here.
Jer Noble
Comment 3
2015-05-06 18:52:06 PDT
Comment on
attachment 252525
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=252525&action=review
>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:303 >> + [[_clipView layer].mask removeAllAnimations]; > > Strange to mix x.layer and [x layer] here.
Id love it if we could use dot-notation with RetainPtr<>. We could also do foo,get().layer.
Jer Noble
Comment 4
2015-05-06 21:10:40 PDT
<
rdar://problem/20702435
>
WebKit Commit Bot
Comment 5
2015-05-06 21:57:33 PDT
Comment on
attachment 252525
[details]
Patch Clearing flags on attachment: 252525 Committed
r183911
: <
http://trac.webkit.org/changeset/183911
>
WebKit Commit Bot
Comment 6
2015-05-06 21:57:37 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug