Bug 144714 – Web Inspector: Docking Toolbar Buttons do not respect Docking Availability

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Docking Toolbar Buttons do not respect Docking Availability.

The backend knows if it should allow / disallow the frontend to attach based on the size of the inspected view. In the past, the window displayed/hid docking buttons depending on this state. With the new tab design, these dock buttons are toolbar buttons in the inspected page, and the inspected page is not updating accordingly.

* STEPS TO REPRODUCE
1. Inspect a page
2. Undock the inspector
3. Resize the inspected page window to be very small
  => Docking buttons in the inspector do nothing.

* EXPECTED
Docking buttons in the inspector should be hidden / disabled when the backend determines docking is not allowed.

[Radar WebKit Bug Importer]

<rdar://problem/20844854>

[Joseph Pecoraro]

Created attachment 252524 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

This hides the buttons, which makes sense for remote cases.
We could alternately disable the buttons.

[Build Bot]

Comment on attachment 252524 [details]
[PATCH] Proposed Fix

Attachment 252524 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5787263740936192

New failing tests:
inspector/model/parse-script-syntax-tree.html
http/tests/inspector/css/bad-mime-type.html
inspector/css/matched-style-properties.html
inspector/protocol-promise-result.html
inspector/event-listener.html
inspector/console/console-api.html
inspector/test-harness-trivially-works.html
inspector/css/pseudo-element-matches.html
inspector/css/selector-specificity.html
inspector/event-listener-set.html

[Build Bot]

Created attachment 252532 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Joseph Pecoraro]

Interesting. Despite running these tests myself I didn't run into the issue. In any case, I'll throw the WebInspectorUI message into a (!m_underTest) block.

[Joseph Pecoraro]

Created attachment 252536 [details]
[PATCH] For Landing

[Build Bot]

Comment on attachment 252536 [details]
[PATCH] For Landing

Attachment 252536 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6610162294980608

New failing tests:
inspector/model/parse-script-syntax-tree.html
http/tests/inspector/css/bad-mime-type.html
inspector/css/matched-style-properties.html
inspector/console/console-api.html
inspector/event-listener.html
inspector/protocol-promise-result.html
inspector/test-harness-trivially-works.html
inspector/css/pseudo-element-matches.html
inspector/css/selector-specificity.html
inspector/event-listener-set.html

[Build Bot]

Created attachment 252541 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Joseph Pecoraro]

Created attachment 252555 [details]
[PATCH] For Landing

Heavier hammer. Stub in Test.js, which oddly enough the update dock side was already doing.

[WebKit Commit Bot]

Comment on attachment 252555 [details]
[PATCH] For Landing

Clearing flags on attachment: 252555

Committed r183907: <http://trac.webkit.org/changeset/183907>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.