Bug 144711 - Perf dashboard treats Speedometer and JetStream as smaller is better
Summary: Perf dashboard treats Speedometer and JetStream as smaller is better
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-06 14:47 PDT by Ryosuke Niwa
Modified: 2016-02-16 13:53 PST (History)
4 users (show)

See Also:

Attachments
Fixes the bug (2.10 KB, patch)
2015-05-06 14:49 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-05-06 14:47:41 PDT 
Fix that.
Comment 1 Ryosuke Niwa 2015-05-06 14:49:31 PDT 
Created attachment 252520 [details]
Fixes the bug
Comment 2 Chris Dumez 2015-05-06 14:50:40 PDT 
Comment on attachment 252520 [details]
Fixes the bug

r=me!
Comment 3 Ryosuke Niwa 2015-05-06 14:51:01 PDT 
Comment on attachment 252520 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=252520&action=review

> Websites/perf.webkit.org/public/js/helper-classes.js:165
> -        'Allocations': 'B'}[suffix];
> +        'Allocations': 'B',
> +        'Score': 'pt'}[suffix];

smallerIsBetter function in v1 returns true if it's equal to 'B' or 'ms'.
Comment 4 Ryosuke Niwa 2015-05-06 14:51:29 PDT 
Committed r183890: <http://trac.webkit.org/changeset/183890>