Bug 144704 - Optimize topLeftLocationOffset() addition in updateLayerPosition
Summary: Optimize topLeftLocationOffset() addition in updateLayerPosition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-06 12:28 PDT by Dave Hyatt
Modified: 2015-05-06 13:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.90 KB, patch)
2015-05-06 12:32 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (10.89 KB, patch)
2015-05-06 12:35 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (10.89 KB, patch)
2015-05-06 12:38 PDT, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-05-06 12:28:27 PDT 
Add a special apply function that can update the point without copies and inline it for speed.
Comment 1 Dave Hyatt 2015-05-06 12:32:09 PDT 
Created attachment 252511 [details]
Patch
Comment 2 Dave Hyatt 2015-05-06 12:35:11 PDT 
Created attachment 252512 [details]
Patch
Comment 3 WebKit Commit Bot 2015-05-06 12:36:29 PDT 
Attachment 252512 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBox.h:557:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Hyatt 2015-05-06 12:38:41 PDT 
Created attachment 252513 [details]
Patch
Comment 5 Dean Jackson 2015-05-06 13:39:36 PDT 
Comment on attachment 252513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252513&action=review

> Source/WebCore/rendering/RenderBox.cpp:4866
> +    containerBlock->flipForWritingMode(rect); // FIXME: This is wrong if we are an absolutely positioned object

Nit: Missing period in comment.
Comment 6 Dave Hyatt 2015-05-06 13:42:23 PDT 
Fixed in r183885.