RESOLVED FIXED 144704
Optimize topLeftLocationOffset() addition in updateLayerPosition 
https://bugs.webkit.org/show_bug.cgi?id=144704
Summary Optimize topLeftLocationOffset() addition in updateLayerPosition
Dave Hyatt
Reported 2015-05-06 12:28:27 PDT
Add a special apply function that can update the point without copies and inline it for speed.
Attachments
Patch (10.90 KB, patch)
2015-05-06 12:32 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (10.89 KB, patch)
2015-05-06 12:35 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (10.89 KB, patch)
2015-05-06 12:38 PDT, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-05-06 12:32:09 PDT
Created attachment 252511 [details] Patch
Dave Hyatt
Comment 2 2015-05-06 12:35:11 PDT
Created attachment 252512 [details] Patch
WebKit Commit Bot
Comment 3 2015-05-06 12:36:29 PDT
Attachment 252512 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBox.h:557: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 4 2015-05-06 12:38:41 PDT
Created attachment 252513 [details] Patch
Dean Jackson
Comment 5 2015-05-06 13:39:36 PDT
Comment on attachment 252513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252513&action=review > Source/WebCore/rendering/RenderBox.cpp:4866 > + containerBlock->flipForWritingMode(rect); // FIXME: This is wrong if we are an absolutely positioned object Nit: Missing period in comment.
Dave Hyatt
Comment 6 2015-05-06 13:42:23 PDT
Fixed in r183885.
Note You need to log in before you can comment on or make changes to this bug.