Bug 144700 – Media Controls: Scrubber should not follow actual video time, causes scrubber to be jumpy

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Roger Fong]

We should
a) draw the scrubber based on the input range position
b) also, update the time and draw the timeline on timelinemousemove, not wrappermousemove.

rdar://problem/19997548

[Roger Fong]

Created attachment 252502 [details]
patch

[Dean Jackson]

Comment on attachment 252502 [details]
patch

I guess we have to do the same for iOS.

[Jer Noble]

Comment on attachment 252502 [details]
patch

This doesn't solve the underlying problem. You are still querying the <video> element's currentTime when interacting with the timeline slider.

[Jer Noble]

Comment on attachment 252502 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252502&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:885
> +            this.updateTime();

updateTime() sets timeline.value based on video.currentTime. That's the underlying problem.

[Roger Fong]

Created attachment 252572 [details]
patch

[Darin Adler]

Comment on attachment 252572 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252572&action=review

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:369
> -        CGContextSetFontAntialiasingStyle(cgContext, kCGFontAntialiasingStyleUnfilteredCustomDilation);
> +        CGContextSetFontAntialiasingStyle(cgContext, kCGFontAntialiasingStyleCustomDilation);

Surely this was included in the patch by accident?

[Roger Fong]

> Surely this was included in the patch by accident?

whoops yup

[Roger Fong]

Created attachment 252597 [details]
patch

[Jer Noble]

Comment on attachment 252597 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252597&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:888
>      handleTimelineMouseMove: function(event)
>      {
> +        this.updateControlsWhileScrubbing();
> +

Shouldn't this be handled in handleTimelineInput()?  (And in handleTimelineChange())? Doing it this way means that the controls won't update when the timeline is changed through Accessibility.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1408
> +        
> +        if (this.isWaitingForBuffer)
> +            return;

Why is this necessary? Surely we're not getting "timechange" events when we're in the "waiting" state.

[Roger Fong]

Created attachment 252603 [details]
patch

[Roger Fong]

(In reply to comment #10)
> Created attachment 252603 [details]
> patch

I think handleTimelineInput is sufficient since we get an input and change event at the same timeline position when ending the scrub.

[Roger Fong]

I should probably do an iOS fix in this patch as well

[Roger Fong]

http://trac.webkit.org/changeset/183953