Bug 144687 - [CSS Grid Layout] Mark grid shorthands as layout dependent
Summary: [CSS Grid Layout] Mark grid shorthands as layout dependent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2015-05-06 08:29 PDT by Manuel Rego Casasnovas
Modified: 2015-06-29 02:53 PDT (History)
4 users (show)

See Also:

Attachments
Example to reproduce the crash (440 bytes, text/html)
2015-05-06 08:29 PDT, Manuel Rego Casasnovas 		no flags Details
Patch (6.31 KB, patch)
2015-05-06 08:36 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2015-05-06 08:29:53 PDT 
Created attachment 252474 [details]
Example to reproduce the crash

If you try to get the computed style of a grid shorthand (grid-template or grid) you'll get a crash if it happens before layout.

To reproduce the issue simply open the attached file (you can check that it happens the same with grid shorthand).

This is the same issue than: https://code.google.com/p/chromium/issues/detail?id=485085
Comment 1 Manuel Rego Casasnovas 2015-05-06 08:36:24 PDT 
Created attachment 252477 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-06 23:08:47 PDT 
Comment on attachment 252477 [details]
Patch

Clearing flags on attachment: 252477

Committed r183913: <http://trac.webkit.org/changeset/183913>
Comment 3 WebKit Commit Bot 2015-05-06 23:08:51 PDT 
All reviewed patches have been landed.  Closing bug.