Bug 144675 - Fix <script srcset> being loaded by the preloader.
Summary: Fix <script srcset> being loaded by the preloader.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-06 00:36 PDT by Yoav Weiss
Modified: 2015-05-07 05:19 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.28 KB, patch)
2015-05-06 00:39 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Patch (6.36 KB, patch)
2015-05-06 00:43 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Patch (5.67 KB, patch)
2015-05-07 00:22 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2015-05-06 00:36:24 PDT
Fix <script srcset> being loaded by the preloader.
Comment 1 Yoav Weiss 2015-05-06 00:39:23 PDT
Created attachment 252458 [details]
Patch
Comment 2 Yoav Weiss 2015-05-06 00:43:40 PDT
Created attachment 252460 [details]
Patch
Comment 3 Yoav Weiss 2015-05-06 00:46:34 PDT
A preloadScanner bug with srcset I found while going over the code is that it would download <script srcset> for no good reason. This patch fixes that.
Comment 4 Darin Adler 2015-05-06 09:21:56 PDT
Comment on attachment 252460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252460&action=review

> LayoutTests/http/tests/loading/preload-script-src-expected.txt:6
> +This test needs to be run in DRT. Preload scanner should see the script resource. 

It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner.

> LayoutTests/http/tests/loading/preload-script-src.html:9
> +This test needs to be run in DRT. Preload scanner should see the script resource.

It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.

> LayoutTests/http/tests/loading/preload-script-srcset-ignored-expected.txt:6
> +This test needs to be run in DRT. Preload scanner should not see the script resource since it's in a srcset attribute. 

It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner.

> LayoutTests/http/tests/loading/preload-script-srcset-ignored.html:9
> +This test needs to be run in DRT. Preload scanner should not see the script resource since it's in a srcset attribute.

It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner.
Comment 5 Yoav Weiss 2015-05-07 00:22:35 PDT
Created attachment 252577 [details]
Patch
Comment 6 WebKit Commit Bot 2015-05-07 01:10:25 PDT
Comment on attachment 252577 [details]
Patch

Clearing flags on attachment: 252577

Committed r183920: <http://trac.webkit.org/changeset/183920>
Comment 7 WebKit Commit Bot 2015-05-07 01:10:30 PDT
All reviewed patches have been landed.  Closing bug.