Bug 144672 – [EFL] Remove redudant condition in ViewClientEfl::didChangeViewportAttributes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

ViewClientEfl::didChangeViewportAttributes() is always called when FixedLayout is enabled.

[Ryuan Choi]

Created attachment 252455 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 252455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252455&action=review

> Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:-134
> -    ewkView->scheduleUpdateDisplay();

Why is this call removed ?

> Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:129
> +    ASSERT(WKPageUseFixedLayout(ewkView->wkPage()));

I wonder why we need to add assert(). Should we generate a crash though this function is always called when fixed layout is disabled ?

[Ryuan Choi]

Comment on attachment 252455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252455&action=review

>> Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:-134
>> -    ewkView->scheduleUpdateDisplay();
> 
> Why is this call removed ?

It has never been called because this method is always called when fixed layout is enabled.

>> Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:129
>> +    ASSERT(WKPageUseFixedLayout(ewkView->wkPage()));
> 
> I wonder why we need to add assert(). Should we generate a crash though this function is always called when fixed layout is disabled ?

In the current logic, it will not be happened that this function is called without fixed layout.

I added assert() to catch the some bad changes earily in the debug build and notify that this method is only called when fixed layout is enabled.

[Gyuyoung Kim]

Comment on attachment 252455 [details]
Patch

ok, r=me.

[WebKit Commit Bot]

Comment on attachment 252455 [details]
Patch

Clearing flags on attachment: 252455

Committed r183864: <http://trac.webkit.org/changeset/183864>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.