Bug 144654 – Fix a build break on EFL debug

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jinwoo Jeong]

There is a build error when compiling EFL debug build.

../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:79:25: error: 'class WebCore::TextureMapper' has no member named 'accelerationMode'
../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:79:47: error: 'OpenGLMode' is not a member of 'WebCore::TextureMapper'
../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: In member function 'void WebKit::CoordinatedGraphicsScene::paintToGraphicsContext(PlatformGraphicsContext*, const WebCore::Color&, bool)':
../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:125:25: error: 'class WebCore::TextureMapper' has no member named 'accelerationMode'
../../Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:125:47: error: 'SoftwareMode' is not a member of 'WebCore::TextureMapper'

[Jinwoo Jeong]

Created attachment 252434 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 252434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252434&action=review

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:-79
> -    ASSERT(m_textureMapper->accelerationMode() == TextureMapper::OpenGLMode);

I think we should keep this assert. If there is build break by code change, we need to support this assert under new code change.

[Hyungwook Lee]

According to https://bugs.webkit.org/show_bug.cgi?id=143561, we only have OpenGL backend in TextureMapper.
So I think we can remove unnecessary assert.

[Gyuyoung Kim]

Comment on attachment 252434 [details]
Patch

I missed that accelerationMode was removed, and we don't need to check it anymore. Because we begin to only support OpenGL mode. Thanks !

[WebKit Commit Bot]

Comment on attachment 252434 [details]
Patch

Clearing flags on attachment: 252434

Committed r183910: <http://trac.webkit.org/changeset/183910>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Ooops, I missed it, thanks for the fix.