Bug 144651 - REGRESSION (r183517): Yellow find-in-page highlight gets stuck forever
Summary: REGRESSION (r183517): Yellow find-in-page highlight gets stuck forever
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-05 17:50 PDT by Tim Horton
Modified: 2015-05-08 02:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.69 KB, patch)
2015-05-05 17:51 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-05-05 17:50:50 PDT 
REGRESSION: Yellow find-in-page highlight gets stuck forever
Comment 1 Tim Horton 2015-05-05 17:51:17 PDT 
Created attachment 252426 [details]
Patch
Comment 2 Tim Horton 2015-05-05 17:51:58 PDT 
<rdar://problem/20755722>
Comment 3 Tim Horton 2015-05-05 17:52:49 PDT 
Comment on attachment 252426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252426&action=review

> Source/WebCore/ChangeLog:5
> +        <rdar://problem/20755722>
> +        https://bugs.webkit.org/show_bug.cgi?id=144651

These are backwards.
Comment 4 mitz 2015-05-05 19:22:06 PDT 
Comment on attachment 252426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252426&action=review

> Source/WebCore/page/mac/TextIndicatorWindow.mm:85
> +@property (nonatomic) BOOL fadingOut;

getter=isFadingOut. Properties normally come before instance methods.

> Source/WebCore/page/mac/TextIndicatorWindow.mm:374
> +    if ([m_textIndicatorView fadingOut])

isFadingOut]

> Source/WebCore/page/mac/TextIndicatorWindow.mm:431
> +    if ([m_textIndicatorView fadingOut])

Ditto.
Comment 5 Tim Horton 2015-05-05 23:28:40 PDT 
Thanks!

http://trac.webkit.org/changeset/183859
Comment 6 Csaba Osztrogonác 2015-05-06 01:46:08 PDT 
(In reply to comment #5)
> Thanks!
> 
> http://trac.webkit.org/changeset/183859

It broke the build on the 32 bit Apple Yosemite bot:
https://build.webkit.org/builders/Apple%20Yosemite%20Release%20%2832-bit%20Build%29/builds/2817
Comment 7 Csaba Osztrogonác 2015-05-08 02:18:32 PDT 
Just to document, it was fixed by https://trac.webkit.org/changeset/183870