Bug 144633 - Only autoplay videos should not automatically play to playback target
Summary: Only autoplay videos should not automatically play to playback target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-05 12:28 PDT by Eric Carlson
Modified: 2015-05-05 13:53 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (2.78 KB, text/plain)
2015-05-05 12:36 PDT, Eric Carlson
no flags Details
Updated patch (3.70 KB, patch)
2015-05-05 13:30 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-05-05 12:28:01 PDT
Refine the selection criteria added in r183613 to allow any video that starts playing from a user gesture to play to target.
Comment 1 Radar WebKit Bug Importer 2015-05-05 12:28:59 PDT
<rdar://problem/20822993>
Comment 2 Eric Carlson 2015-05-05 12:36:51 PDT
Created attachment 252397 [details]
Proposed patch
Comment 3 Eric Carlson 2015-05-05 13:30:21 PDT
Created attachment 252400 [details]
Updated patch
Comment 4 WebKit Commit Bot 2015-05-05 13:32:35 PDT
Attachment 252400 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Carlson 2015-05-05 13:53:03 PDT
Committed r183826: https://trac.webkit.org/r183826