Bug 144619 – Rename ProcessThrottlerClient::{send, cancel}ProcessWillSuspend() to {send, cancel}PrepareToSuspend()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Daniel Bates]

The names of the functions ProcessThrottlerClient::{send, cancel}ProcessWillSuspend() are misnomers. These functions are called when
the ProcessThrottler wants to prepare the process that it manages for suspension and changes it mind, respectively. That is, these
functions do not actually correspond to the OS decision to suspend a process or cancel the suspension of a process. We should rename
these functions to better describe their purpose.

[Daniel Bates]

Created attachment 252366 [details]
[Patch] Rename ProcessThrottlerClient functions

I am open to name suggestions.

[Radar WebKit Bug Importer]

<rdar://problem/20812779>

[Daniel Bates]

Created attachment 252367 [details]
[Patch] Rename ProcessThrottlerClient functions

[Andy Estes]

Comment on attachment 252367 [details]
[Patch] Rename ProcessThrottlerClient functions

"process" seems redundant, since in each case that term is already in the class name. What about prepareToSuspend() and cancelPrepareToSuspend()?

[Daniel Bates]

Created attachment 252989 [details]
Patch

Renamed ProcessThrottlerClient::{send, cancel}ProcessWillSuspend() to {send, cancel}PrepareToSuspend().

[Daniel Bates]

Created attachment 252990 [details]
Patch

[Andy Estes]

Comment on attachment 252990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252990&action=review

> Source/WebKit2/ChangeLog:10
> +        and changes it mind, respectively. That is, these functions do not actually correspond to the OS decision to

changes its mind

> Source/WebKit2/ChangeLog:11
> +        suspend a process or cancel the suspension of a process. We should rename these functions an associated

and associated

[Daniel Bates]

Committed r184326: <http://trac.webkit.org/changeset/184326>