Bug 144596 - Add a WKView SPI to get the window used for taking back/forward snapshots
Summary: Add a WKView SPI to get the window used for taking back/forward snapshots
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-04 14:24 PDT by Ada Chan
Modified: 2015-05-05 20:56 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2015-05-04 15:02 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2015-05-04 14:24:21 PDT 
Add a WKView SPI to get the window used for taking back/forward snapshots.  

Proposed signature of that SPI is:
- (NSWindow *)_windowForTakingSnapshot;

This is needed for <rdar://problem/20681226>
Comment 1 Ada Chan 2015-05-04 15:02:43 PDT 
Created attachment 252337 [details]
Patch
Comment 2 Tim Horton 2015-05-04 15:11:11 PDT 
Comment on attachment 252337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252337&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3374
> +    NSWindow *window = self._windowForTakingSnapshot;

How does the

    windowCaptureRect = [self convertRect:unobscuredBounds toView:nil];

below deal with this?
Comment 3 Ada Chan 2015-05-04 16:17:52 PDT 
We'll try to accomplish what we need without this change.  Closing the bug.
Comment 4 Daniel Bates 2015-05-05 20:56:42 PDT 
Comment on attachment 252337 [details]
Patch

Clearing review flag to remove this patch from the review queue.