Bug 144591 – Add overflow and iframe scroll-snap tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brent Fulgham]

The existing handfull of scroll-snap tests are focused on main frame (fast scrolling) scroll-snap points. We need to make sure that the overflow scroll-snap feature does not regress.

[Brent Fulgham]

Created attachment 252387 [details]
Patch

[Brent Fulgham]

This patch also includes iframe scroll tests.

[Simon Fraser (smfr)]

Comment on attachment 252387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252387&action=review

> LayoutTests/ChangeLog:16
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources/horizontal-mainframe.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources/vertical-mainframe.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up-expected.txt: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe-expected.txt: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-expected.txt: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html: Added.

It would be nice to have some WK1-main frame scroll and overflow-scrolling tests too.

> LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html:26
> +        function locationInWindowCoordinates(element) {

Normal JS convention is brace on new line (like C++).

[Brent Fulgham]

(In reply to comment #3)
> It would be nice to have some WK1-main frame scroll and overflow-scrolling
> tests too.

Will do!

> > LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html:26
> > +        function locationInWindowCoordinates(element) {
> 
> Normal JS convention is brace on new line (like C++).

Fixed.

[Brent Fulgham]

Committed r183823: <http://trac.webkit.org/changeset/183823>