RESOLVED FIXED144585
Optimize WeakBlock's "reap" and "visit" operations. 
https://bugs.webkit.org/show_bug.cgi?id=144585
Summary Optimize WeakBlock's "reap" and "visit" operations.
Andreas Kling
Reported 2015-05-04 10:20:44 PDT
WeakBlock's reap() and visit() could be a lot faster if they stopped doing so many paranoid address checks. Have patch, will post.
Attachments
Patch idea (10.15 KB, patch)
2015-05-04 10:21 PDT, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-04 10:21:38 PDT
Created attachment 252319 [details] Patch idea
Geoffrey Garen
Comment 2 2015-05-04 10:46:01 PDT
Comment on attachment 252319 [details] Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=252319&action=review r=me > Source/JavaScriptCore/heap/MarkedBlock.h:415 > + inline bool MarkedBlock::isLiveForWeakBlockScan(const JSCell* cell) Let's call this isMarkedOrNewlyAllocated, and have isLive call it. That way, the MarkedBlock class is not responsible for promising that it's right to call this during weak block scan. It's only responsible for providing the answer that it knows. > Source/JavaScriptCore/heap/WeakBlock.h:74 > + void didDetachFromMarkedBlock() { m_markedBlock = nullptr; } I think we usually call this "disconnectMarkedBlock".
Andreas Kling
Comment 3 2015-05-04 13:43:30 PDT
Committed r183769: <http://trac.webkit.org/changeset/183769>
Andreas Kling
Comment 4 2015-05-05 00:26:27 PDT
mac-mavericks perf bot says this was a 3.2% progression on Dromaeo/dom-modify :)
Note You need to log in before you can comment on or make changes to this bug.