Bug 144566 - [cmake] ARM related build system cleanup
Summary: [cmake] ARM related build system cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-04 04:09 PDT by Csaba Osztrogonác
Modified: 2015-05-04 16:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2015-05-04 04:10 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-05-04 04:09:27 PDT
Now some ARM specific files are added conditionally.
These files are guarded properly and the other platform
files are added unconditionally too.

if (WTF_CPU_ARM)
    list(APPEND JavaScriptCore_SOURCES
        assembler/ARMAssembler.cpp
        assembler/ARMv7Assembler.cpp
        assembler/MacroAssemblerARM.cpp
    )
...
endif()
Comment 1 Csaba Osztrogonác 2015-05-04 04:10:31 PDT
Created attachment 252305 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-04 16:48:04 PDT
Comment on attachment 252305 [details]
Patch

Clearing flags on attachment: 252305

Committed r183779: <http://trac.webkit.org/changeset/183779>
Comment 3 WebKit Commit Bot 2015-05-04 16:48:08 PDT
All reviewed patches have been landed.  Closing bug.