Bug 144554 - [GTK][SOUP] Web and Network processes don't know how to get memory size on OSX
Summary: [GTK][SOUP] Web and Network processes don't know how to get memory size on OSX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.10
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 126492
  Show dependency tree / graph
 
Reported: 2015-05-03 15:39 PDT by Philip Chimento
Modified: 2015-05-10 20:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch for 2.6.x (1.72 KB, patch)
2015-05-03 15:42 PDT, Philip Chimento 		no flags Details | Formatted Diff | Diff
Patch (4.91 KB, patch)
2015-05-07 22:48 PDT, Philip Chimento 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Chimento 2015-05-03 15:39:32 PDT 
The Soup backend has apparently never been compiled on OSX before, so it needs Darwin-specific code.

Although perhaps given #144081's recent landing, WebProcesSoup and NetworkProcessSoup should be ported to use WTF::ramSize?
Comment 1 Philip Chimento 2015-05-03 15:42:04 PDT 
Created attachment 252287 [details]
Patch for 2.6.x

This patch applies to 2.6.x, which doesn't have WTF::ramSize yet.
Comment 2 WebKit Commit Bot 2015-05-03 15:45:17 PDT 
Attachment 252287 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Csaba Osztrogonác 2015-05-04 08:28:14 PDT 
changelog please
Comment 4 Darin Adler 2015-05-04 15:54:54 PDT 
Should use a shared function, not local copies in two different source files of a function that definitely exists somewhere else in WebKit.
Comment 5 Philip Chimento 2015-05-07 22:48:12 PDT 
Created attachment 252686 [details]
Patch
Comment 6 Philip Chimento 2015-05-07 22:48:43 PDT 
Added changelog.
Comment 7 WebKit Commit Bot 2015-05-10 20:10:36 PDT 
Comment on attachment 252686 [details]
Patch

Clearing flags on attachment: 252686

Committed r184064: <http://trac.webkit.org/changeset/184064>
Comment 8 WebKit Commit Bot 2015-05-10 20:10:41 PDT 
All reviewed patches have been landed.  Closing bug.