RESOLVED FIXED 144541
[GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main loop 
https://bugs.webkit.org/show_bug.cgi?id=144541
Summary [GTK] Async operations running in the WorkQueue thread should schedule their ...
Carlos Garcia Campos
Reported 2015-05-03 03:58:47 PDT
They are currently sent to the main thread run loop, because we are not setting the WorkQueue main context as the default one in the worker thread.
Attachments
Patch (6.26 KB, patch)
2015-05-03 04:04 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-05-03 04:04:40 PDT
Created attachment 252263 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-03 04:06:52 PDT
Attachment 252263 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp:58: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2015-05-04 00:14:14 PDT
Comment on attachment 252263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252263&action=review > Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp:58 > + [](GObject*, GAsyncResult*, gpointer userData) { It's not terribly important here, but if following the usual pattern of condition usage you'd be expected to lock the context.m_lock mutex inside the lambda.
Carlos Garcia Campos
Comment 4 2015-05-05 01:17:42 PDT
Committed r183800: <http://trac.webkit.org/changeset/183800>
Note You need to log in before you can comment on or make changes to this bug.