Bug 14454 - Truncated values in option pop-ups (used to affect united.com)
Summary: Truncated values in option pop-ups (used to affect united.com)
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://www.united.com/
Keywords: HasReduction
: 11204 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-28 21:52 PDT by Gavin Sherlock
Modified: 2020-10-23 13:32 PDT (History)
8 users (show)

See Also:


Attachments
Reduction without adding any new code (1.13 KB, text/html)
2007-12-17 01:34 PST, Sam Stigler
no flags Details
More succinct (i.e., better) reduction (243 bytes, text/html)
2007-12-17 01:35 PST, Sam Stigler
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Sherlock 2007-06-28 21:52:57 PDT
At united.com the popup menus used to select the dates for a flight (left hand side of the page) have values which appear truncated.  Looks fine in Firefox.  Tested with r23841.
Comment 1 mitz 2007-06-29 01:29:10 PDT
Compared to Firefox, the popups are the same width and the font is the same size, but WebKit leaves less room for the text.
Comment 2 Alexey Proskuryakov 2007-07-06 03:53:46 PDT
*** Bug 11204 has been marked as a duplicate of this bug. ***
Comment 3 Gavin Sherlock 2007-07-06 07:22:40 PDT
Added NeedsReduction keyword
Comment 4 Sam Stigler 2007-12-17 01:34:17 PST
Created attachment 17957 [details]
Reduction without adding any new code

Although this reduction is somewhat more true to form in that it stays with the original code of the page, look at reducedmore.html (the next attachment) for a much more succinct reduction; one that doesn't include any Javascript.
Comment 5 Sam Stigler 2007-12-17 01:35:55 PST
Created attachment 17958 [details]
More succinct (i.e., better) reduction
Comment 6 Sam Stigler 2007-12-17 01:38:27 PST
Comment on attachment 17958 [details]
More succinct (i.e., better) reduction

The issue appears to be that the width of <select> element is manually set too thin in its 'style' attribute.  If you remove the 'style' attribute from the <select> elements, they will behave as expected.
Comment 7 David Kilzer (:ddkilzer) 2007-12-17 08:10:42 PST
Thanks for the reduction, Sam!  This is clearly an Evangelism issue.

Bug 13610 is a similar evangelism issue for Hotwire.com email messages.

Comment 8 mitz 2007-12-17 08:17:36 PST
(In reply to comment #7)
> This is clearly an Evangelism issue.

As I wrote,

> Compared to Firefox, the popups are the same width and the font is the same
> size, but WebKit leaves less room for the text.

Can we offer the websites in question any solution that will work with both Firefox and Safari? Maybe WebKit's popup button inner metrics should be reconsidered?
Comment 9 David Kilzer (:ddkilzer) 2007-12-17 08:35:17 PST
(In reply to comment #8)
> > Compared to Firefox, the popups are the same width and the font is the same
> > size, but WebKit leaves less room for the text.
> 
> Can we offer the websites in question any solution that will work with both
> Firefox and Safari? Maybe WebKit's popup button inner metrics should be
> reconsidered?

At what point do we stop trying to fit the text into the element, though?  A style of "width: 1px"?

If we changed the font metrics (kerning, etc.) to match Firefox, would these pop-up buttons look out-of-place with the rest of the page in Safari?

Unless we can make a one-time change to the font metrics, it seems like this would be a slippery slope.

Another solution may be to use an ellipsis if we know the text won't fit in the width provided (assuming the ellipsis would fit itself!).

Does HTML5 have anything to say about fitting text into a pop-up button when you start changing the width style (on any input element)?
Comment 10 mitz 2007-12-17 09:24:07 PST
Actually, Firefox 3, which uses Aqua buttons, truncates the text just like Safari, so I don't think changes to WebKit should be considered.
Comment 11 Julio Danni 2010-01-14 08:15:50 PST
It's working fine to me with Chrome 4, webkit 532.5
Comment 12 Gavin Sherlock 2010-01-14 08:18:59 PST
Did you look at the reduction?  The reduction still shows the problem in Webkit r53178.  The united.com site has changed since I reported the bug, so can't be used to demonstrate it anymore.
Comment 13 Julio Danni 2010-01-14 08:26:33 PST
(In reply to comment #12)
> Did you look at the reduction?
Sorry, I did not. Anyway, I think this bug should be closed, since the page has changed and evangelism isn't needed anymore. I apologize if I'm wrong.
Comment 14 David Kilzer (:ddkilzer) 2010-01-14 14:37:38 PST
(In reply to comment #13)
> (In reply to comment #12)
> > Did you look at the reduction?
> Sorry, I did not. Anyway, I think this bug should be closed, since the page has
> changed and evangelism isn't needed anymore. I apologize if I'm wrong.

I think it should be kept open.