Bug 144533 – REGRESSION (r183467): Unable to start downloads on macupdate.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Wade]

https://www.macupdate.com/app/mac/39855/soundcloud-downloader/download5/2/15 18:36:24.991 

Regular Safari performs this download without problem.

Possible relevant Console message-

secd[365]:  securityd_xpc_dictionary_handler SafariForWebKitD[27320] update The operation couldn’t be completed. (OSStatus error -34018 - client has neither application-identifier nor keychain-access-groups entitlements)

[Wade]

5/2/15 18:36:24.993 secd[365]:  securityd_xpc_dictionary_handler SafariForWebKitD[27320] add The operation couldn’t be completed. (OSStatus error -34018 - client has neither application-identifier nor keychain-access-groups entitlements)

Possible relevant Console log.

[Alexey Proskuryakov]

*** Bug 144532 has been marked as a duplicate of this bug. ***

[Radar WebKit Bug Importer]

<rdar://problem/20812658>

[Antti Koivisto]

I can repro in private browsing mode.

[Antti Koivisto]

Created attachment 252472 [details]
patch

[Darin Adler]

Comment on attachment 252472 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252472&action=review

> Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:334
> +    ResourceLoadPriority oldPriority = priority();
> +    RefPtr<FormData> oldHTTPBody = httpBody();
> +    bool isHiddenFromInspector = hiddenFromInspector();
> +    auto oldRequester = requester();

What makes these the only 4 we need to preserve? I think there should be a comment here explaining the theory of which properties should be listed here.

[Antti Koivisto]

https://trac.webkit.org/r183875

[Alexey Proskuryakov]

This reproduced in regular mode, not in private browsing. Are you sure that you fixed the right bug?

[Alexey Proskuryakov]

From the nature of the fix, it may have depended on Do Not Track settings in Safari, so it may be the right fix. But please test carefully once a nightly comes out.

[Antti Koivisto]

Any client feature that mutates the request in willSendRequest would trigger this. One that I could find was private browsing.