Bug 144529 – display:none iframes cause repeated compositing flushing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

display:none iframes cause repeated compositing flushing

[Simon Fraser (smfr)]

Created attachment 252244 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/20791708>

[Build Bot]

Comment on attachment 252244 [details]
Patch

Attachment 252244 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6614108027748352

New failing tests:
compositing/iframes/display-none-subframe.html

[Build Bot]

Created attachment 252247 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Darin Adler]

Comment on attachment 252244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252244&action=review

New test is failing on Mac WebKit 1 build bot:
  compositing/iframes/display-none-subframe.html [ Failure ]

r=me but I am worried that the test fails

> Source/WebCore/page/FrameView.cpp:2599
> +    FrameViewList childViews = renderedChildFrameViews();
> +    for (auto& frameView : childViews) {

Will work just as well without a local variable:

    for (auto& frameView : renderedChildFrameViews()) {

> Source/WebCore/page/FrameView.cpp:4034
> +    FrameViewList childViews;

Might want to reserveInitialCapacity.

> Source/WebCore/page/FrameView.cpp:4037
> +            childViews.append(*frame->view());

If so, then could use uncheckedAppend.

> Source/WebCore/page/FrameView.cpp:4064
> +    FrameViewList childViews = renderedChildFrameViews();
> +    for (auto& frameView : childViews)

Will work just as well without a local variable:

    for (auto& frameView : renderedChildFrameViews())

[Simon Fraser (smfr)]

> > Source/WebCore/page/FrameView.cpp:4034
> > +    FrameViewList childViews;
> 
> Might want to reserveInitialCapacity.

But it's a linear walk of child Frames to count them :(

[Simon Fraser (smfr)]

https://trac.webkit.org/r183777