Bug 144519 - REGRESSION: Web Inspector: Switching recordings in the Timeline navigation bar is broken
Summary: REGRESSION: Web Inspector: Switching recordings in the Timeline navigation ba...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks: 144520
  Show dependency treegraph
 
Reported: 2015-05-02 02:51 PDT by Timothy Hatcher
Modified: 2015-05-04 12:35 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.17 KB, patch)
2015-05-02 03:00 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-05-02 02:51:17 PDT
The view state is messed up when switching recordings from the navigation bar.

There is an exception but there is more broken after that is fixed.
Comment 1 Radar WebKit Bug Importer 2015-05-02 02:51:37 PDT
<rdar://problem/20790228>
Comment 2 Timothy Hatcher 2015-05-02 03:00:03 PDT
Created attachment 252226 [details]
Patch
Comment 3 Joseph Pecoraro 2015-05-04 11:54:41 PDT
Comment on attachment 252226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252226&action=review

r=me

> Source/WebInspectorUI/ChangeLog:21
> +        to state restoration here. If the view existed before, use its state. If now, use the current state that

Typo: "now" => "not"
Comment 4 WebKit Commit Bot 2015-05-04 12:34:58 PDT
Comment on attachment 252226 [details]
Patch

Clearing flags on attachment: 252226

Committed r183762: <http://trac.webkit.org/changeset/183762>
Comment 5 WebKit Commit Bot 2015-05-04 12:35:01 PDT
All reviewed patches have been landed.  Closing bug.