Bug 144518 – Web Inspector: Current time marker is always at zero in Rendering Frames ruler

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

Created attachment 252224 [details]
Screenshot

The marker should be hidden if we don't plan to use it. Or it should be animated along the ruler as the recording happens.

You can see it in the corner of the screenshot. You need to move the time selection to see it.

[Radar WebKit Bug Importer]

<rdar://problem/20790062>

[Matt Baker]

Created attachment 253087 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 253087 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=253087&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:431
>          if (this._renderingFrameTimeline && this.currentTimelineView.representedObject.type === WebInspector.TimelineRecord.Type.RenderingFrame) {

Is this called when you switch from the regular timeline to the rendering frame timeline? (Will it show the right end time and current time if this wasn't the current timeline view?)

[Matt Baker]

(In reply to comment #3)
> Comment on attachment 253087 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253087&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:431
> >          if (this._renderingFrameTimeline && this.currentTimelineView.representedObject.type === WebInspector.TimelineRecord.Type.RenderingFrame) {
> 
> Is this called when you switch from the regular timeline to the rendering
> frame timeline? (Will it show the right end time and current time if this
> wasn't the current timeline view?)

Good point, we should just check for this._renderingFrameTimeline here.

[Matt Baker]

Created attachment 253095 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 253095 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 253095

Committed r184336: <http://trac.webkit.org/changeset/184336>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.