Bug 144498 - Inline some small methods instead of them being EXPORT'd and out of line
Summary: Inline some small methods instead of them being EXPORT'd and out of line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-01 13:07 PDT by Joseph Pecoraro
Modified: 2015-05-01 17:01 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.29 KB, patch)
2015-05-01 13:07 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-01 13:07:03 PDT 
* SUMMARY
Inline some small methods instead of them being EXPORT'd and out of line.

The EXPORT should not be needed if the methods are inlined.
Comment 1 Joseph Pecoraro 2015-05-01 13:07:52 PDT 
Created attachment 252167 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2015-05-01 16:12:01 PDT 
Comment on attachment 252167 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=252167&action=review

> Source/WebCore/page/Page.h:443
> +    RefPtr<WheelEventTestTrigger> testTrigger() const { return m_testTrigger; }

Reading this I realize that this accessor should return a raw pointer, not a RefPtr.
Comment 3 WebKit Commit Bot 2015-05-01 17:01:16 PDT 
Comment on attachment 252167 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 252167

Committed r183700: <http://trac.webkit.org/changeset/183700>
Comment 4 WebKit Commit Bot 2015-05-01 17:01:20 PDT 
All reviewed patches have been landed.  Closing bug.