144481 – AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes

Bug 144481 - AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes

Summary: AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Accessibility (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Joanmarie Diggs

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2015-04-30 17:57 PDT by Joanmarie Diggs
Modified:	2015-05-01 10:07 PDT (History)
CC List:	9 users (show)

See Also:

Attachments
Patch (1.85 KB, patch) 2015-05-01 00:09 PDT, Joanmarie Diggs	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joanmarie Diggs 2015-04-30 17:57:04 PDT

See bug 142719 comment 139.

STDERR: ASSERTION FAILED: !needsStyleRecalc() || !document().childNeedsStyleRecalc()
STDERR: ../../Source/WebCore/dom/Element.cpp(483) : virtual bool WebCore::Element::isFocusable() const
STDERR: 1   0x7f7200253b8e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f7200253b8e]
STDERR: 2   0x7f7205e48abd /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Element::isFocusable() const+0xbf) [0x7f7205e48abd]
STDERR: 3   0x7f7205a97754 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AccessibilityNodeObject::determineAccessibilityRole()+0x456) [0x7f7205a97754]
STDERR: 4   0x7f7205a96abf /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AccessibilityNodeObject::init()+0x5d) [0x7f7205a96abf]
STDERR: 5   0x7f7205a73b50 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AXObjectCache::getOrCreate(WebCore::Node*)+0x2b4) [0x7f7205a73b50]
STDERR: 6   0x7f7206c26681 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged(WebCore::Node*, WebCore::Node*)+0xb7) [0x7f7206c26681]
STDERR: 7   0x7f7205a756c6 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::AXObjectCache::handleFocusedUIElementChanged(WebCore::Node*, WebCore::Node*)+0x3e) [0x7f7205a756c6]
STDERR: 8   0x7f7205deb6cc /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Document::setFocusedElement(WTF::PassRefPtr<WebCore::Element>, WebCore::FocusDirection)+0x80e) [0x7f7205deb6cc]
STDERR: 9   0x7f7206431844 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::FocusController::setFocusedElement(WebCore::Element*, WTF::PassRefPtr<WebCore::Frame>, WebCore::FocusDirection)+0x43e) [0x7f7206431844]
STDERR: 10  0x7f7205e4fa9d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::Element::focus(bool, WebCore::FocusDirection)+0x14f) [0x7f7205e4fa9d]
STDERR: 11  0x7f7206e7c3d7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebCore::jsElementPrototypeFunctionFocus(JSC::ExecState*)+0x158) [0x7f7206e7c3d7]
STDERR: 12  0x7f71a9fff0a8 [0x7f71a9fff0a8]

Comment 1 Radar WebKit Bug Importer 2015-04-30 17:57:17 PDT

<rdar://problem/20774263>

Comment 2 Joanmarie Diggs 2015-04-30 19:11:48 PDT

Removing the associated commit. I just took a look at earlier builds and it seems this was crashing at least as far back r172891 (1488) -- the earliest one in the list of results. So it's hard to say when this broke.

Comment 3 Joanmarie Diggs 2015-05-01 00:09:05 PDT

Created attachment 252135 [details]
Patch

Comment 4 Joanmarie Diggs 2015-05-01 06:34:20 PDT

Chris or Mario: If you have time for a review, it would be great. Thanks! (It's a tiny patch.)

Comment 5 WebKit Commit Bot 2015-05-01 10:07:08 PDT

Comment on attachment 252135 [details]
Patch

Clearing flags on attachment: 252135

Committed r183678: <http://trac.webkit.org/changeset/183678>

Comment 6 WebKit Commit Bot 2015-05-01 10:07:13 PDT

All reviewed patches have been landed.  Closing bug.