Bug 144467 - Fix text track language selection logic
Summary: Fix text track language selection logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-30 13:07 PDT by Eric Carlson
Modified: 2015-05-01 09:59 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch. (16.22 KB, text/plain)
2015-04-30 13:21 PDT, Eric Carlson 		no flags Details
Proposed patch. (15.32 KB, patch)
2015-04-30 13:27 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-04-30 13:07:00 PDT 
Two tracks with the same language but different locales are weighted equally, causing the incorrect track to be chosen some of the time.
Comment 1 Eric Carlson 2015-04-30 13:07:34 PDT 
<rdar://problem/20653145>
Comment 2 Eric Carlson 2015-04-30 13:21:42 PDT 
Created attachment 252082 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2015-04-30 13:23:07 PDT 
Attachment 252082 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4409:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2015-04-30 13:27:34 PDT 
Created attachment 252083 [details]
Proposed patch.
Comment 5 Brent Fulgham 2015-05-01 08:52:06 PDT 
Comment on attachment 252083 [details]
Proposed patch.

r=me
Comment 6 WebKit Commit Bot 2015-05-01 09:58:56 PDT 
Comment on attachment 252083 [details]
Proposed patch.

Clearing flags on attachment: 252083

Committed r183676: <http://trac.webkit.org/changeset/183676>
Comment 7 WebKit Commit Bot 2015-05-01 09:59:01 PDT 
All reviewed patches have been landed.  Closing bug.