Bug 144462 - Move all of the branchIs<type> helpers from SpeculativeJIT into AssemblyHelpers
Summary: Move all of the branchIs<type> helpers from SpeculativeJIT into AssemblyHelpers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 144396
  Show dependency tree / graph
 
Reported: 2015-04-30 11:37 PDT by Filip Pizlo
Modified: 2015-04-30 17:08 PDT (History)
11 users (show)

See Also:

Attachments
it begins (21.92 KB, patch)
2015-04-30 11:49 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
almost done (51.19 KB, patch)
2015-04-30 16:13 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (57.16 KB, patch)
2015-04-30 16:27 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (57.17 KB, patch)
2015-04-30 16:31 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
the patch (57.17 KB, patch)
2015-04-30 16:50 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-04-30 11:37:29 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-04-30 11:49:44 PDT 
Created attachment 252076 [details]
it begins
Comment 2 Filip Pizlo 2015-04-30 16:13:18 PDT 
Created attachment 252102 [details]
almost done
Comment 3 Filip Pizlo 2015-04-30 16:27:09 PDT 
Created attachment 252108 [details]
the patch
Comment 4 Filip Pizlo 2015-04-30 16:30:34 PDT 
Comment on attachment 252108 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252108&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3968
> -    fastFalse.append(branchNotString(rightRegs.payloadGPR()));
> +    fastFalse.append(m_jit.branchIfNotCell(rightRegs.payloadGPR()));

This looks busted.
Comment 5 Filip Pizlo 2015-04-30 16:30:46 PDT 
(In reply to comment #4)
> Comment on attachment 252108 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252108&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3968
> > -    fastFalse.append(branchNotString(rightRegs.payloadGPR()));
> > +    fastFalse.append(m_jit.branchIfNotCell(rightRegs.payloadGPR()));
> 
> This looks busted.

Fixed locally.
Comment 6 Filip Pizlo 2015-04-30 16:31:22 PDT 
Created attachment 252110 [details]
the patch
Comment 7 Geoffrey Garen 2015-04-30 16:48:29 PDT 
Comment on attachment 252110 [details]
the patch

r=me if unbusted
Comment 8 Filip Pizlo 2015-04-30 16:50:01 PDT 
Created attachment 252114 [details]
the patch

More build/correctness fixing.
Comment 9 Mark Lam 2015-04-30 17:03:25 PDT 
Comment on attachment 252114 [details]
the patch

r=me too
Comment 10 Filip Pizlo 2015-04-30 17:08:26 PDT 
Landed in http://trac.webkit.org/changeset/183656