GTK icons for bug 18530.
<rdar://problem/20766903>
Taking.
Created attachment 252075 [details] Patch
Comment on attachment 252075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252075&action=review rs=me, it would be funny if this lands before the other console.info change lands =) > Source/WebInspectorUI/UserInterface/Images/gtk/Debug.svg:1 > +<?xml version="1.0" encoding="UTF-8" standalone="no"?> I commented on another patch that I don't think the standalone="no" lines are needed. You should be able to remove them and simplify things a bit more. > Source/WebInspectorUI/UserInterface/Images/gtk/Debug.svg:5 > + <path style="color:#000000" d="m10.025 3.125 4.875 4.875l-4.875 4.875h-7.3412c-0.4311-0.018-0.784-0.4-0.784-0.813v-8.125c0-0.4308 0.2808-0.812 0.8197-0.812z" fill="#729fcf"/> One thing we have been doing with our SVGs is adding a class name denoting a path that is filled versus stroked. <path d="..." class="filled" fill="..."/> <path d="..." class="stroked" stroke="..."/> The class names serve no purpose right now, but in the past we have used CSS to customize the stroke / fill color of SVG images. You may want to adopt this pattern too. There are no plans to use it, we have just been proactively adding it.
(In reply to comment #4) > > Source/WebInspectorUI/UserInterface/Images/gtk/Debug.svg:1 > > +<?xml version="1.0" encoding="UTF-8" standalone="no"?> > > I commented on another patch that I don't think the standalone="no" lines > are needed. You should be able to remove them and simplify things a bit more. Yep. > > Source/WebInspectorUI/UserInterface/Images/gtk/Debug.svg:5 > > + <path style="color:#000000" d="m10.025 3.125 4.875 4.875l-4.875 4.875h-7.3412c-0.4311-0.018-0.784-0.4-0.784-0.813v-8.125c0-0.4308 0.2808-0.812 0.8197-0.812z" fill="#729fcf"/> > > One thing we have been doing with our SVGs is adding a class name denoting a > path that is filled versus stroked. > > <path d="..." class="filled" fill="..."/> > <path d="..." class="stroked" stroke="..."/> > > The class names serve no purpose right now, but in the past we have used CSS > to customize the stroke / fill color of SVG images. You may want to adopt > this pattern too. There are no plans to use it, we have just been > proactively adding it. I'm adding this now. Thanks a lot for your review.
Created attachment 252379 [details] Patch for landing
Created attachment 252380 [details] Patch for landing
Comment on attachment 252380 [details] Patch for landing Clearing flags on attachment: 252380 Committed r183804: <http://trac.webkit.org/changeset/183804>
All reviewed patches have been landed. Closing bug.