Bug 144453 - Decrease minimum Vector size
Summary: Decrease minimum Vector size
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on: 144594
Blocks:
  Show dependency treegraph
 
Reported: 2015-04-30 10:04 PDT by Alex Christensen
Modified: 2015-05-05 00:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.16 KB, patch)
2015-04-30 10:05 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
results of run-jsc-benchmarks (42.39 KB, text/plain)
2015-04-30 10:06 PDT, Alex Christensen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-04-30 10:04:19 PDT
jsc benchmarks indicate that shrinking small Vectors doesn't slow things down much, but we'll probably save memory.
Comment 1 Alex Christensen 2015-04-30 10:05:54 PDT
Created attachment 252065 [details]
Patch
Comment 2 Alex Christensen 2015-04-30 10:06:59 PDT
Created attachment 252066 [details]
results of run-jsc-benchmarks
Comment 3 Andreas Kling 2015-04-30 17:51:12 PDT
Comment on attachment 252065 [details]
Patch

Ok, let's do it. r=me
Comment 4 WebKit Commit Bot 2015-04-30 18:39:43 PDT
Comment on attachment 252065 [details]
Patch

Clearing flags on attachment: 252065

Committed r183661: <http://trac.webkit.org/changeset/183661>
Comment 5 WebKit Commit Bot 2015-04-30 18:39:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2015-05-04 13:40:10 PDT
Re-opened since this is blocked by bug 144594
Comment 7 Alex Christensen 2015-05-05 00:22:24 PDT
It is very strange that this increased memory usage, but the bot doesn't lie.  We could look into this more closely, but that would require much more than this one-number change.